Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIfTI-2 Support #96

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

NIfTI-2 Support #96

wants to merge 21 commits into from

Conversation

liningpan
Copy link

This PR is based on #90 , and resolved most issues raised in the original PR, including getters / Into&From traits. The PR also resolved several merge conflicts with current master.

Regarding using f32 for nifti1 when every possible, I don't think it's quite possible with the current NiftiHeader design

pub enum NiftiHeader {
    /// The underlying header version is `NIFTI-1`.
    Nifti1Header(Nifti1Header),
    /// The underlying header version is `NIFTI-2`.
    Nifti2Header(Nifti2Header),
}

We might need to make NiftiHeader a trait with a floating number type defined separately for Nifti1 and Nifti2

@nilgoyette
Copy link
Collaborator

Thank you @liningpan. I started reviewing but I stopped because I'm curious about @benkay86 opinion. Is this what you had in mind?

If I may ask, do you guys know each other? Why did you continue his work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants