avoid // where breaks Devel::Cover

EntropyOrg · Nov 5, 2024 · b3f456d · b3f456d · mohawk2 · Nov 5, 2024
1 parent 7249231
commit b3f456d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/Data/Frame.pm b/lib/Data/Frame.pm
@@ -1137,8 +1137,10 @@ method split (ColumnLike $factor) {
     if ($factor->$_DOES('PDL::Factor')) {
         $factor = $factor->{PDL};
     }
-    my $uniq_values = $factor->$_call_if_can('uniq')
-      // [ List::AllUtils::uniq( $factor->flatten ) ];
+    # avoid // as breaks Devel::Cover
+    my $uniq_values = $factor->$_call_if_can('uniq');
+    $uniq_values = [ List::AllUtils::uniq( $factor->flatten ) ]
+      if !defined $uniq_values;
 
     my @rslt = map {
         my $indices = PDL::Primitive::which( $factor == $_ );
@@ -1390,7 +1392,9 @@ method _compare ($other, $mode) {
         return sub {
             my ( $col, $x ) = @_;
             my $col_isbad = $col->isbad;
-            my $x_isbad   = $x->$_call_if_can('isbad') // 1;
+            # avoid // as breaks Devel::Cover
+            my $x_isbad = $x->$_call_if_can('isbad');
+            $x_isbad = 1 if !defined $x_isbad;
             my $both_bad  = ( $col_isbad & $x_isbad );
 
             my $rslt = $f->( $col, $x );

diff --git a/lib/Data/Frame/Partial/Sugar.pm b/lib/Data/Frame/Partial/Sugar.pm
@@ -82,7 +82,9 @@ use overload (
         if ( $caller eq 'Method::Generate::Accessor::_Generated' ) {
             return $self;
         }
-        return ( $self->_tie_hash // $self );
+        my $tmp = $self->_tie_hash; # avoid // as breaks Devel::Cover
+        $tmp = $self if !defined $tmp;
+        $tmp;
     },
     fallback => 1
 );