Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative heights of the editor widgets #123

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

JamesWrigley
Copy link
Member

Spotted in #119 (comment).

@JamesWrigley JamesWrigley added bug Something isn't working GUI For GUI-related things labels Nov 1, 2023
@JamesWrigley JamesWrigley self-assigned this Nov 1, 2023
@takluyver
Copy link
Member

So you're going back to the pre-#119 heights? I had assumed you were deliberately making the error widget a bit bigger (from 1/7 to 1/6).

@JamesWrigley
Copy link
Member Author

Correct, I actually have no idea why I changed that in the first place 🙃 But it should be as small as possible in the case where there are no errors and doesn't need to be larger.

@takluyver
Copy link
Member

OK, then LGTM 👍

@JamesWrigley JamesWrigley merged commit 842a567 into master Nov 2, 2023
1 check passed
@JamesWrigley JamesWrigley deleted the widget-size branch November 2, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI For GUI-related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants