-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karabo-bridge-serve-run command #458
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a0f059c
Split out serve_data function and show moree info while streaming
takluyver e97f0cb
Fix getting length of deque
takluyver 2d4f64d
Print final update when streaming finishes
takluyver eae9935
Add karabo-bridge-serve-run command
takluyver 0e3d0df
karabo-bridge-serve-run: only send complete trains by default
takluyver a67217f
Fix parameters to serve_data()
takluyver cda0b9c
Ensure print_update() can't have an undefined variable
takluyver 73208fc
Make --port an option
takluyver 10f145a
Document karabo-bridge-serve-run command
takluyver 4554836
Add a test for karabo-bridge-serve-run
takluyver 505aa3b
Simplify test
takluyver a46793d
Recreate raw+proc folder tree for each test using it
takluyver f15401c
Give test subprocesses a chance to exit cleanly
takluyver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, I have used the old command (only) for streaming from a run directory, using the full path as argument. Apart from the fact that
...-serve-run
is indeed more convenient to achieve this, what would be the main use case for using the old command now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
-serve-files
command makes it easy to stream from a non-standard run directory location, e.g. if we do an experimental correction of a run, we might put it in proposalscratch
. Or it gives you a way to stream fromred
before we've integrated support for that. Or if users transfer run data back to their home institution and want to use EXtra-data there. I think the new-serve-run
command will be better for ~95% of use cases.The biggest reason to retain the old command is compatibility & familiarity, though - don't break what's working for people. 🙂