Fix pulse slicing code to advance to next train on same pulse ID #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsmt
force-pushed
the
fix/adq-single-pulse-data
branch
from
0978698 to
707eb58
Compare
philsmt
force-pushed
the
fix/adq-single-pulse-data
branch
from
707eb58 to
7ad2850
Compare
|
LGTM; could have a test, but I don't think it's essential |
|
I fully agree, but the testing infrastructure for this component requries some minor polishing. This bug is too serious to have it wait, though. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native pulse slicing code compares subsequent pulse IDs to advance from train to train. In the case of a single pulse, this value never changes, thus reading the same (first) train over and over.