Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #59

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add documentation #59

wants to merge 4 commits into from

Conversation

tmichela
Copy link
Member

@tmichela tmichela commented May 6, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented May 6, 2020

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files           8        8           
  Lines         520      520           
=======================================
  Hits          427      427           
  Misses         93       93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1972140...d7810df. Read the comment docs.

@takluyver
Copy link
Member

We should remember to remove this from the user docs, and link to the new docs instead. IIRC, we had the idea that the it was best to keep all the documentation of Karabo bridge protocol & clients in one place, but it's never easy to maintain docs far away from the code they relate to.

@tmichela
Copy link
Member Author

tmichela commented May 7, 2020

We should remember to remove this from the user docs,

Yes I will once this is hosted on RTD.

IIRC, we had the idea that the it was best to keep all the documentation of Karabo bridge protocol & clients in one place, but it's never easy to maintain docs far away from the code they relate to.

Yes, I remember that. But since this has a few more feature (simulation, server, serialziers) I figured that make sens to have the whole documentation in here. Also probably is is easier to find for people if it is next to the code.
The one part I not sure about if the specifics for usage at EuXFEL (https://in.xfel.eu/readthedocs/docs/data-analysis-user-documentation/en/latest/online.html#how-to-use-it-at-the-euxfel). It maybe that should stay in the user documentation (adding a link here pointing to it)

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files           8        8           
  Lines         520      520           
=======================================
  Hits          427      427           
  Misses         93       93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1972140...16d2be2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants