UVD: Remove unnecessary UI elements when the selected unit does not have a special armorType

[Basilisk3]

Description of the proposed changes

This is only a small UI tweak for units without a special armorType like, for example, the Striker. The current armorType portion of uvd.lua looks like this for these units:

Armor Type: Normal          (% of damage taken)
Normal - 100.0

This is the new output:

Armor Type: Normal

Both (% of damage taken) and Normal - 100.0 do not provide the player with any relevant information, so they can be hidden.

Testing done on the proposed changes

Only affects units without a special armorType.

Checklist

• Changes are documented in the changelog for the next game version

[lL1l1]

What if a mod changes the normal armor to take different damage from something else? I think an armor type's properties should not be shown only if they are all 1x damage taken.

[Basilisk3]

I applied your feedback. Unfortunately, reliably removing (% of damage taken) when nothing is displayed underneath it has proven difficult, so I kept it.

[lL1l1]

If you don't mind I added a way that removes the "% of damage taken" text. Basically table.insert can insert at the first position, making it easy to keep everything the same then just add the header line in the beginning of the lines, after checking if the armor type takes any adjusted damages.

[Basilisk3]

Thanks, tested and works.

[BlackYps]

Good thinking here so far. While reading the discussion I was wondering if it makes sense to even display the armor type: Normal in this situation? Maybe we should display nothing at all?
I don't really have an opinion on this yet, just wanted to throw it into the discussion.

[lL1l1]

I think it's best to display it so that players and modders know that armor types exist, even if normal armor doesn't have any special modifiers.

[BlackYps]

Makes sense