Disable collisions with dead units consistently

[lL1l1]

Issue

This bit of code runs for all units and causes them to wait while dead before being destroyed, making them block damage when they shouldn't:

fa/lua/sim/Unit.lua

Lines 1982 to 1994 in 9948335

	DestroyUnit = function(self, overkillRatio)
	self:CreateWreckage(overkillRatio or self.overkillRatio)
	-- wait at least 1 tick before destroying unit
	WaitSeconds(math.max(0.1, self.DeathThreadDestructionWaitTime))
	-- do not play sound after sinking
	if not self.Sinking then
	self:PlayUnitSound('Destroyed')
	end
	self:Destroy()
	end,

This code does the same, but makes up a much more significant portion of the wait time (0-0.5 seconds vs 0.1)

fa/lua/sim/Unit.lua

Lines 1921 to 1924 in 9948335

	DeathThread = function(self, overkillRatio, instigator)
	local isNaval = EntityCategoryContains(categories.NAVAL, self)
	local shallSink = self:ShallSink()
	WaitSeconds(utilities.GetRandomFloat(self.DestructionExplosionWaitDelayMin, self.DestructionExplosionWaitDelayMax))

For a practical example, spawn a line of hives and an enemy monkeylord. The monkeylord's laser will be blocked while the dead hive is going through its explosion FX.

Description of the proposed changes

• add DisallowCollisions = true to OnKilled as that is the entry point for all the issues that arise with collisions after death (DeathThreadDestructionWaitTime, sinking, and death animations)
  • remove the statement in the sinking and death animation cases as it is no longer necessary

Testing done on the proposed changes

• Monkeylord can laser through a line of hives without getting blocked
• Monkeylord can kill a cruiser, then kill another cruiser spawned 1 ogrid behind the dead one (the sinking cruiser's hitbox remains on the surface)
• Monkeylord can kill a monkeylord and the laser immediately goes through to a target behind the monkeylord in the death animation

Additional context

This does not apply to air units because they overwrite OnKilled.

Checklist

• Changes are annotated, including comments where useful
• Changes are documented in the changelog for the next game version

[clyfordv]

Changes work as advertised. Looks better IMO, definitely a bit of buff to continuous heavy beam weapons.