Annotate code related to collision beam entities #6627
+90
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec is from the disassembly strings `Disable` is from logging the `moho.CollisionBeamEntity` table (excluding what's already in `moho.entity_methods`)
Type doesn't propagate without using Class(base)(spec), even though base(spec) is functional. Not sure how to fix that.
The beam is only instantiated once so we don't need to do the metatable trick we did with projectiles
lL1l1
added
area: sim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Annotate collision beam entities, the default beam weapon class, and related Intellisense warnings.
Testing done on the proposed changes
DefaultBeamWeapon, CollisionBeam, and CollisionBeamEntity files don't have warnings
Checklist