Check if instigator is destroyed in Fatboy DeathThread
#6629
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Since the instigator is used in a thread, and threads start 1 tick later, it can be passed from OnKilled and then get destroyed.
Replay: https://replay.faforever.com/24087043 Right side fatboy for south team at 29:00 errors out when dying
Error:
Description of the proposed changes
GetPositionXYZ
on it. I didn't opt for usingUnit.Dead
because this code won't run often and.Dead
is true after dying, which is before C-object destruction.Testing done on the proposed changes
DeathThread
s use the instigator value.Checklist