adding flag option

FairwindsOps · Jul 22, 2024 · bced211 · bced211
1 parent ec80be4
commit bced211
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/pkg/kube/kube.go b/pkg/kube/kube.go
@@ -29,7 +29,7 @@
 package kube
 
 import (
-	"os"
+	"flag"
 	"sync"
 
 	"k8s.io/client-go/kubernetes"
@@ -81,10 +81,9 @@ func GetConfig(kubeContext string, kubeConfigPath string) (*rest.Config, error)
 		klog.V(3).Infof("using kube context: %s", kubeContext)
 	}
 
-	if kubeConfigPath != "" {
-		klog.V(3).Infof("using kubeconfig at path: %s", kubeConfigPath)
-		os.Setenv("KUBECONFIG", kubeConfigPath)
-	}
+	fs := flag.NewFlagSet("fs", flag.ContinueOnError)
+	fs.String("kubeconfig", kubeConfigPath, "")
+	config.RegisterFlags(fs)
 
 	kubeConfig, err := config.GetConfigWithContext(kubeContext)
 	if err != nil {

diff --git a/pkg/kube/kube_test.go b/pkg/kube/kube_test.go
@@ -58,6 +58,20 @@ func Test_getKubeClient(t *testing.T) {
 			kubeConfigPath: "",
 			wantErr:        true,
 		},
+		{
+			name:           "valid kubeconfig path",
+			kubeContext:    "kind-kind",
+			kubeConfig:     "testdata/kubeconfig_invalid",
+			kubeConfigPath: "testdata/kubeconfig",
+			wantErr:        false,
+		},
+		{
+			name:           "invalid kubeconfig path",
+			kubeContext:    "kind-kind",
+			kubeConfig:     "testdata/kubeconfig",
+			kubeConfigPath: "testdata/kubeconfig_invalid",
+			wantErr:        true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {