Use Appium.WebDriver instead of Selenium.WebDriver for tests. #28
Conversation
This allows the `Get Element Attribute` test in FlaUI#27 to work. Seems like Selenium.WebDriver tries to execute a script in order to read attributes?
|
|
||
| var title = driver.Title; | ||
|
|
||
| Assert.That(title, Is.EqualTo("FlaUI WPF Test App")); | ||
| } | ||
|
|
||
| [Test] | ||
| [Ignore("AppiumOptions prefixes timeouts with 'appium:' prefix. Not sure what to do here.")] |
There was a problem hiding this comment.
Note sure what to do here? Maybe timeouts should have the prefix, maybe it shouldn't? I'm not familiar enough with this area to say.
There was a problem hiding this comment.
I would like to keep support for the WebDriver2 "timeouts" capability (see WebDriver2 capabilities here). The Appium standard does not describe an "appium:timeouts" capability, so prefixing it is not valid.
Can't we use the named properties ImplicitWaitTimeout, PageLoadTimeout, ScriptTimeout instead?
There was a problem hiding this comment.
Note those are supported when you update the Selenium.WebDriver dependency to 4.20.0...
|
Converting this to a draft as it's not actually needed for #27. Feel free to close if you'd prefer. |
|
Actually, going to close this for now. I've not run into anything else that would require it so far. |
Note sure if this is desired or not, but this allows the
Get Element Attributetest in #27 to work. Seems likeSelenium.WebDrivertries to execute a script in order to read attributes?