Trigger the cron job right after the first configuration #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TyMarc
force-pushed
the
mahinse/run_cron_job_post_configuration
branch
3 times, most recently
from
acc6673 to
cb59201
Compare
Comment on lines
129
to
148
| async function updateEventIngestionCronJobInterval( | ||
| service: SplunkService, | ||
| intervalInSeconds: number | ||
| ): Promise<void> { | ||
| await updateConfigurationFile( | ||
| service, | ||
| 'inputs', | ||
| 'script://$SPLUNK_HOME/etc/apps/flare/bin/cron_job_ingest_events.py', | ||
| { | ||
| interval: `${intervalInSeconds}`, | ||
| } | ||
| ); |
There was a problem hiding this comment.
I wonder if we should put a retry mechanism in here should the request fail for whatever reason.
There was a problem hiding this comment.
it might be worth it even if the requests are running locally, wouldn't do it in this PR though.
markkasaboski
approved these changes
Nov 20, 2024
TyMarc
force-pushed
the
mahinse/run_cron_job_post_configuration
branch
from
cb59201 to
6db9e17
Compare
TyMarc
force-pushed
the
mahinse/run_cron_job_post_configuration
branch
from
6db9e17 to
af22b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.