Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors test_ingest_events.py removing Mocks #69

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

markkasaboski
Copy link
Collaborator

No description provided.

@markkasaboski markkasaboski self-assigned this Nov 28, 2024
@markkasaboski markkasaboski marked this pull request as draft November 28, 2024 21:16
@markkasaboski markkasaboski force-pushed the mark/refactor-event-ingest-tests branch from 4e062ab to cbbb048 Compare November 28, 2024 21:16
packages/flare/tests/bin/test_ingest_events.py Outdated Show resolved Hide resolved
packages/flare/tests/bin/conftest.py Outdated Show resolved Hide resolved
@markkasaboski markkasaboski force-pushed the mark/refactor-event-ingest-tests branch 11 times, most recently from 54d5eef to d9fc6a3 Compare November 29, 2024 21:29
@markkasaboski markkasaboski marked this pull request as ready for review November 29, 2024 21:29
@markkasaboski markkasaboski force-pushed the mark/refactor-event-ingest-tests branch from d9fc6a3 to ff3818c Compare November 29, 2024 21:43
Copy link
Contributor

@TyMarc TyMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that's great!

@markkasaboski markkasaboski merged commit cb9f782 into main Nov 29, 2024
2 checks passed
@markkasaboski markkasaboski deleted the mark/refactor-event-ingest-tests branch November 29, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants