chore: remove broken size badge from README #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gksander
approved these changes
Jun 10, 2022
sauliuskerusauskas
deleted the
chore/remove-broken-size-badge-from-readme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
README.mdthe un-compressed size badge appears with a 'critical error' instead of the size.It appears that providing an absolute URL to the
badge-sizeservice is currently broken for getting the non gzipped size while gzipped sizes still work. There is an issue in thebadge-sizeproject: ngryman/badge-size#94 but it has been open for a little while now.I noticed other repos of ours only display the gzipped size. Removing the un-compressed size from the
README.mdso the 'critical error' doesn't unnecessarily worry anyone.