Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored code to include a _initialise_structure function, a comput… #40

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

AndySAnker
Copy link
Collaborator

…e_iq function, etc. This modulates the code and makes it shorter. It also makes it possible to calculate Fq and Gr directly from Sq data, which can also be done on experimental datasets.

…e_iq function etc.. this modulises the code and make it shorter. It also makes it possible to calculate Fq and Gr directly from Sq data, which can also be done on experimental datasets
@FrederikLizakJohansen
Copy link
Owner

I've done some benchmarking to see if this version performs as well as the old, and it seems to be!

  • Running gr with low statistics (10 reps) on bigger particles reveals no difference in performance. Although at generation time, we do see a small increase in memory usage. This however is so small in comparison to the memory at calculation time, that I would argue that the utility of this refactored version outweighs the small increase in memory.
  • Running gr with high statistics (1k reps) on smaller particles sizes (needed for consistency), reveal no noticeable difference. Although again we see the same, but insignificant, increase in memory at generation time.

image
image

@AndySAnker
Copy link
Collaborator Author

Great work Frederik, I propose that we merge.

@FrederikLizakJohansen FrederikLizakJohansen merged commit cf1631a into main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants