-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs!: optimizing frontend apps #3573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danielbate
requested review from
digorithm,
arboleya,
Torres-ssf and
nedsalk
as code owners
January 10, 2025 12:27
danielbate
commented
Jan 10, 2025
arboleya
approved these changes
Jan 10, 2025
Torres-ssf
approved these changes
Jan 10, 2025
nedsalk
approved these changes
Jan 10, 2025
petertonysmith94
approved these changes
Jan 10, 2025
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoCost
helper for transaction requests #3535submitAndAwaitStatus
at provider level #3526Release notes
In this release, we:
Summary
This PR primarily adds a dedicated page on optimizing transactions for apps and an advanced react example that utilises the techniques.
However some other decisions have been made in this PR, around the premise of transaction optimisation techniques:
Provider.sendTransactionAndAwaitStatus()
and the contents of #3526 has been reverted. Rather than adding unnecessary bloat, we will just recommendProvider.sendTransaction()
andProvider.waitForResult()
. For accounts wanting to side-step any account level abstractions tosendTransaction()
, they should fund and sign a request prior, and then use the provider to send the transaction, rather than the account. This technique is used in the added docs.ScriptTransactionRequest.autoCost()
has been renamed toScriptTransactionRequest.estimateAndFund()
as this seemed more appropriate. andBaseInvocationScope.autoCost()
has been renamed back toBaseInvocationScope.fundWithRequiredCoins()
as it is a relatively hidden method and to minimise breaking changes on the release. This was initially introduced in #3535.Breaking Changes
ScriptTransactionRequest.autoCost()
has been renamed toScriptTransactionRequest.estimateAndFund()
, initially introduced by Introduce theautoCost
helper for transaction requests #3535BaseInvocationScope.autoCost()
has been renamed back toBaseInvocationScope.fundWithRequiredCoins()
, initially introduced by Introduce theautoCost
helper for transaction requests #3535Checklist