Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more vaults and param updates #723

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

0xdcota
Copy link
Contributor

@0xdcota 0xdcota commented Aug 17, 2023

This pull requests addresses issue with rebalancer which fixed the eth-mainnet vaults with morpho as a provider.

In addition, the following vaults were deployed:

Ethereum:
WETH-USDT with Morphos as providers
WETH-DAI with Spark and Morphos

Arbitrum:
WETH-USDT with AaveV3 and DForce

Gnosis:
WETH-DAI with Agave
WBTC-DAI with Agave
WBTC-USDC with Agave

Optimism:
WETH-USDT with Dforce and Aave

Polygon
WETH-USDT with AaveV2, AaveV3 and DForce
All of below with AaveV3
STMATIC-WMATIC
STMATIC-MATICX
MATICX-WMATIC

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fuji-v2-frontend ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2023 1:55pm

@0xdcota
Copy link
Contributor Author

0xdcota commented Aug 24, 2023

@ferostabio could you please help me check what I am doing wrong, I try to compile front-end to visualize the new vaults and it is throwing error: error - Error: Invariant failed: Missing address! which I found where it is but don't really understand why is affecting.

@ferostabio
Copy link
Contributor

@ferostabio could you please help me check what I am doing wrong, I try to compile front-end to visualize the new vaults and it is throwing error: error - Error: Invariant failed: Missing address! which I found where it is but don't really understand why is affecting.

Fixed :). You were treating xDai as a token, when its a native currency -there's a clear disctintion between the two of them in the sdk: tokens can't have address zero, but native currencies do.

Copy link
Contributor

@brozorec brozorec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daigarocota the errors that were displayed might be related to the fact the addresses of the two of the vaults are wrong.

@@ -194,7 +194,25 @@
"liqRatio": 820000000000000000,
"maxLtv": 780000000000000000,
"name": "BorrowingVault-WETHUSDC-3",
"providers": ["Morpho_Compound", "Morpho_Aave_V2"],
"providers": ["Morpho_Aave_V2","Morpho_Compound","Compound_V3"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting: space after the comma

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that, though I just ran the standard json formatting and it breaks the providers like this:

{
      "collateral": "WETH",
      "debt": "USDC",
      "liqRatio": 820000000000000000,
      "maxLtv": 780000000000000000,
      "name": "BorrowingVault-WETHUSDC-3",
      "providers": [
        "Morpho_Aave_V2",
        "Morpho_Compound",
        "Compound_V3"
      ],
      "rating": 85
    },

Would this be ok?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if yes 👍, I will run it in all deploy-configs.

"liqRatio": 820000000000000000,
"maxLtv": 780000000000000000,
"name": "BorrowingVault-WETHUSDT-1",
"providers": ["Morpho_Aave_V2","Morpho_Compound"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting: space after the comma

"liqRatio": 820000000000000000,
"maxLtv": 800000000000000000,
"name": "BorrowingVault-WETHDAI-1",
"providers": ["Spark","Morpho_Compound", "Morpho_Aave_V2"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting: space after the comma

"name": "BorrowingVault-MATICXUSDC-1",
"providers": ["Aave_V3_Polygon"],
"providers": ["Aave_V3_Polygon","Compound_V3_Polygon"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting: space after the comma

"liqRatio": 820000000000000000,
"maxLtv": 800000000000000000,
"name": "BorrowingVault-WETHUSDT-1",
"providers": ["Aave_V2_Polygon", "Aave_V3_Polygon","DForce_Polygon"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting: space after the comma

@ferostabio
Copy link
Contributor

@daigarocota we should probably ask @Markoyw for all assets before he takes time off !

@0xdcota 0xdcota marked this pull request as ready for review August 26, 2023 13:14
@0xdcota 0xdcota requested a review from brozorec August 26, 2023 13:14
Copy link
Contributor

@brozorec brozorec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After 3f02348

  1. There's no oracle for stMatic on Polygon (deploy-configs)
  2. The address of stMatic in the SDK was wrong
  3. There was the same vault appearing twice in the SDK's vaults.ts
  4. Commented out some borrowing vaults where the initialization didn't happen properly and the totalDebt is 0. Can you verify everything's fine there?

@0xdcota
Copy link
Contributor Author

0xdcota commented Aug 29, 2023

I will follow up on this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants