processEnv - initial module; #1796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Can you move the mapp_env module to the mod/utils directory and rename this to processEnv since this isn't really related to the mapp library but deals with the process environment for the xyz node modules. Can you also move the globale env typedef from the api module into the processEnv utility module. I had a look at the sonarcloud issues.
This can be fixed by assigning true or false boolean in the processEnv module. |
|
You can fix the optional chaining warning like so:
Same should work here: |
|
I have some ideas for us avoiding importing the env utility module everywhere. I will do this tomorrow |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a process env module which passes environment variables and assigns defaults in order to avoid referencing process.env across the codebase.