Gsa/production release #731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiwang-gsa
requested changes
Jan 10, 2025
| setError(error) | ||
| } | ||
|
|
||
| isLoading.value = false |
There was a problem hiding this comment.
maybe isLoading and showSpinner reset can be in finally block instead to ensure isLoading and showSpinner are reset even exception happending?
There was a problem hiding this comment.
Added reset of isLoading and showSpinner boolean values in a finally block
| {value: 'Travel Training for Card/Account Holders and Approving Officials', label: 'Travel Training for Card/Account Holders and Approving Officials'}, | ||
| ]; | ||
|
|
||
| const v_all_info$ = useVuelidate(validation_info, user_input) |
There was a problem hiding this comment.
useVuelidate by default probably can't handle completation_date_range date compare, maybe helpers also need to be imported to add customized date validation to handle start date greater than end date issue. Currently, if I put start date greater than end date and hit submit, it display "please ender a valid date" for end date, which is not correct, as "01/11/2022" is valid date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprint 46 issues included:
BUG: Admin/User Profile Saved Changes are Not Displayed on Results screen #709
BUG: Insert a space between the date field of Completion date range end and Quiz type(s) on the SmartPay Training Report #705 Customizable Training Report for A/OPC #633