Frontend/create room #127
Merged
Frontend/create room #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawnglede
reviewed
Dec 7, 2023
packages/frontend/js/api/index.ts
Outdated
| msg: string | ||
| rooms: Record<string, create_room> | ||
| } | ||
|
|
There was a problem hiding this comment.
有注意到這裡跟types.ts裡的內容是重複的，感覺可以直接import進來就好~
dawnglede
reviewed
Dec 7, 2023
packages/frontend/js/api/index.ts
Outdated
| status: string | ||
| totalUsers: number | ||
| } | ||
|
|
There was a problem hiding this comment.
這邊的create_room跟底下的specific_room，建議名稱可以再重新想一下，重複名稱容易造成混淆
added 8 commits
December 9, 2023 15:54
…game into frontend/CreateRoom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #119, #124