Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix StreamChannel not available in various poll dialogs #2082

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

xsahil03x
Copy link
Member

This pull request addresses a bug fix in the stream_chat_flutter package, ensuring that the StreamChannel is properly available in the widget tree for various poll-related dialogs. The changes primarily involve wrapping the ValueListenableBuilder in a StreamChannel widget to provide the necessary context.

Bug Fixes:

Poll Dialogs:

@xsahil03x xsahil03x requested a review from deven98 January 13, 2025 17:20
deven98
deven98 previously approved these changes Jan 13, 2025
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 60.15%. Comparing base (b9871eb) to head (e165585).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tter/lib/src/poll/stream_poll_comments_dialog.dart 0.00% 11 Missing ⚠️
.../lib/src/poll/stream_poll_option_votes_dialog.dart 0.00% 8 Missing ⚠️
...utter/lib/src/poll/stream_poll_results_dialog.dart 0.00% 8 Missing ⚠️
...utter/lib/src/poll/stream_poll_options_dialog.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
- Coverage   60.17%   60.15%   -0.02%     
==========================================
  Files         372      372              
  Lines       22766    22773       +7     
==========================================
  Hits        13699    13699              
- Misses       9067     9074       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsahil03x xsahil03x requested a review from deven98 January 13, 2025 18:01
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xsahil03x xsahil03x merged commit 3e95b11 into master Jan 15, 2025
12 of 14 checks passed
@xsahil03x xsahil03x deleted the fix/poll-stream-channel-not-available branch January 15, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants