-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): fix StreamChannel not available in various poll dialogs #2082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2082 +/- ##
==========================================
- Coverage 60.17% 60.15% -0.02%
==========================================
Files 372 372
Lines 22766 22773 +7
==========================================
Hits 13699 13699
- Misses 9067 9074 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request addresses a bug fix in the
stream_chat_flutter
package, ensuring that theStreamChannel
is properly available in the widget tree for various poll-related dialogs. The changes primarily involve wrapping theValueListenableBuilder
in aStreamChannel
widget to provide the necessary context.Bug Fixes:
packages/stream_chat_flutter/CHANGELOG.md
: Added a note about the fix forStreamChannel
not being available in the widget tree for various poll options.Poll Dialogs:
packages/stream_chat_flutter/lib/src/poll/stream_poll_comments_dialog.dart
: WrappedValueListenableBuilder
in aStreamChannel
widget to ensure the channel context is available. [1] [2]packages/stream_chat_flutter/lib/src/poll/stream_poll_option_votes_dialog.dart
: WrappedValueListenableBuilder
in aStreamChannel
widget to ensure the channel context is available. [1] [2]packages/stream_chat_flutter/lib/src/poll/stream_poll_options_dialog.dart
: WrappedValueListenableBuilder
in aStreamChannel
widget to ensure the channel context is available. [1] [2]packages/stream_chat_flutter/lib/src/poll/stream_poll_results_dialog.dart
: WrappedValueListenableBuilder
in aStreamChannel
widget to ensure the channel context is available. [1] [2]