Do not use view context in StreamChat #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
added
the
🌐 SDK: StreamChat (LLC)
laevandus
commented
Jan 3, 2025
| let context = viewContext | ||
| let context = backgroundReadOnlyContext |
There was a problem hiding this comment.
This was a mistake in PR:3541
Generated by 🚫 Danger |
laevandus
commented
Jan 3, 2025
Comment on lines
-13
to
18
| @MainActor public func makeConnectedUser() throws -> ConnectedUser { | ||
| let user = try CurrentUserDTO.load(context: databaseContainer.viewContext) | ||
| public func makeConnectedUser() throws -> ConnectedUser { | ||
| let user = try databaseContainer.readAndWait { session in | ||
| guard let dto = session.currentUser else { throw ClientError.CurrentUserDoesNotExist() } | ||
| return try dto.asModel() | ||
| } | ||
| return ConnectedUser(user: user, client: self) |
There was a problem hiding this comment.
All our other make methods do not require @MainActor, therefore we should skip it here as well. Downside is that this change would generate a warning that no await is needed if it was called outside of MainActor. Can we make this change?
SDK Size
|
SDK Performance
|
SDK Size
|
martinmitrevski
approved these changes
Jan 3, 2025
Comment on lines
-13
to
18
| @MainActor public func makeConnectedUser() throws -> ConnectedUser { | ||
| let user = try CurrentUserDTO.load(context: databaseContainer.viewContext) | ||
| public func makeConnectedUser() throws -> ConnectedUser { | ||
| let user = try databaseContainer.readAndWait { session in | ||
| guard let dto = session.currentUser else { throw ClientError.CurrentUserDoesNotExist() } | ||
| return try dto.asModel() | ||
| } | ||
| return ConnectedUser(user: user, client: self) |
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
🎯 Goal
Do not use
viewContextin LLC📝 Summary
🛠 Implementation
We should use background context for reading and
writableContextfor writing. There is not need forviewContextanymore. Remove viewContext references from LLC (except DataContainer). Many of our tests still accessviewContext.🎨 Showcase
🧪 Manual Testing Notes
N/A
☑️ Contributor Checklist
docs-contentrepo