Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing URL password #1069

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

bittrance
Copy link
Contributor

When a GitHub app wants to clone a private repo, it is required to pass the access token as a part of the URL https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation 😒 . A gix-url user may want to use Url to store the validared Url internally, but the access token is retrieved at runtime, so such an application will want to clone the Url and set the password just before fetching the private repo.

@Byron Byron merged commit 4ba43ac into GitoxideLabs:main Oct 17, 2023
18 checks passed
@Byron
Copy link
Member

Byron commented Oct 17, 2023

Thanks a lot! Now the API is finally symmetric.

gix-url started out a little bit restrictive about password to the point where one couldn't even query them, but fortunately these dark ages are over now :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants