Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks a lot for gix! I've been playing with it on and off for a while now and am very impressed with the speed and quality of your work.
One of the things I've done is implement my own version of
git log -- somefile
, which led me to doing my own rename detection and then my results started looking different from gix'sWhat follows is a patch to fix what I believe is the bug: removed_bytes is being overwritten every time the sink looks at a hunk of changes.
(Qualifying the
sum()
assum::<usize>()
is required due to multiple impls of std::ops::AddAssign on the type)