-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check periodically for validity of Endaoment projects #1628
Comments
@divine-comedian needs to find the id of the projects and add it to the CSV |
Still need to get project Ids along with mainnet address to properly map them together |
@HrithikSampson can take on this one with guidance from @mohammadranjbarz once it is unblocked by meee |
We'll need to use this list of ~3613 projects that need to be checked monthly for new description and title in addition these projects should be added to the list of project data we check periodically Ukraine America Initiative Reef Guardians Hawaii Mindfulness Through Play SOLUTIONS PROJECT INC Peace Winds America Love Justice International Metagovernance Project Inc |
@HrithikSampson this should be unblocked now - you have the project IDs to start creating the checker service for testing purposes we should try to set a higher frequency - perhaps every 24 hours - being mindful of any impact on server resources. Additionally once this issue passes QA we should change this cronjob to run every month to not affect resource consumption |
@kkatusic is this the issue you worked on to get endaoment project information periodically? |
I didn't work on this issue, I will now ;) |
@divine-comedian do Endaoment projects have option to change wallet address or title or description inside our dApp? Asking this because if something has been changed, such as the project title, the only link I have left is the address, but if someone change address we have a problem |
The project owner COULD, but probably would never happen. We have set one project owner for all endaoment projects ( |
@divine-comedian and that implicate that some project maybe have some changes :( |
It's okay if we overwrite changes, the goal of this is that the project info on endaoment (title, description) will match what is on Giveth projects. Also if project gets delisted or removed from Endaoment that we also cancel the corresponding project on Giveth side |
updated new CSV file to migration, now needs to check, add new column fill endaomentID to projects then setup some cronJobs etc.. |
@divine-comedian do we some restriction using Endaoment API system, I didn't find anything about inside their documentation? thx |
No specific instructions, they just asked us not to hit it too hard |
How should I test this issue? |
@maryjaf, many projects have been changed by this update, some of them for example that had "&" mark inside title, that mark is not showing on our website, but after update it should. Also for example projects that have inside name/title some dot(s) it should be also visible after update. I need to check when update finish, it's cronjob and let you know to check it. |
@maryjaf can you test it please? |
have the updates finished? |
@maryjaf, no, cron job is running but not updating still investigate |
@maryjaf cron job fixed, project have been updated on staging. How you can test, you can choose for example 5 projects from AdminJS, 2 cancelled, to active, check their data on staging dApp also on Endaoment website. Title and description should be same, also cancelled project wont bea ctive on Endaoment website. |
Thanks @kkatusic I've check some cancelled and active project and it works as expected |
I noticed some issues as well related to what @maryjaf is reporting and left them in this issue - Giveth/giveth-dapps-v2#4934 |
So it isn’t related to this issue And we can call it done? @divine-comedian |
it could be related to this issue, I'm not sure.. we'll have to let @kkatusic investigate |
We should periodically (~1 month) check for updates on our import Endaoment projects. This should be able to be done by their API
We should check and update the following fields if there are new changes.
If the query returns a response indicating that it has been offboarded from Endaoment we should change the projects status to cancelled.
Endaoment just published new rest APIs that can let us fetch project information by ID
https://api.endaoment.org/oas#/EndaomentSdk/getOrgsById
projects ID
We'll need to use this list of ~3613 projects that need to be checked monthly for new description and title
org-with-ids.csv
in addition these projects should be added to the list of project data we check periodically
Ukraine America Initiative
https://app.endaoment.org/orgs/88-2280006
Project ID: 0ede481a-c59c-4201-8b0c-69e375cdd7ea
Category: Disaster Preparedness and Relief Services
Reef Guardians Hawaii
https://app.endaoment.org/orgs/47-3975420
Project ID: 2627e4ee-f713-4298-84d2-9fbad53d9ed9
category: Water Resource, Wetlands Conservation and Management
Mindfulness Through Play
https://app.endaoment.org/orgs/82-4211804
Project ID: 2d257c44-c39e-4f41-b4b4-24dd732f545d
Category: Student Services and Organizations
SOLUTIONS PROJECT INC
https://app.endaoment.org/orgs/46-3811348
Project ID: a60836a2-f06e-4b5b-9354-584a4ca5b4b0
Category: Energy Resources Conservation and Development
Peace Winds America
https://app.endaoment.org/orgs/26-3744952
Project ID: 25b2e4a9-20de-4564-be24-fc523a22d65c
Category: Disaster Preparedness and Relief Services
Love Justice International
https://app.endaoment.org/orgs/71-0982808
Project ID: c8101dbe-f308-425c-a0a5-39a98316c02f
Category: Victims' Services
Metagovernance Project Inc
https://app.endaoment.org/orgs/85-3442527
Project ID: d94cdffb-50cc-4127-806d-051b26f5ce00
Category: Computer Science
The text was updated successfully, but these errors were encountered: