Fix/removing endaomentId from update

[kkatusic]

• Check periodically for validity of Endaoment projects #1628

Summary by CodeRabbit

• Refactor
  • Removed endaomentId property from ProjectUpdate class
  • Updated project query to exclude cancelled projects when checking and updating projects

[coderabbitai]

Walkthrough

The pull request involves two key changes: removing the endaomentId property from the ProjectUpdate class in project.ts and modifying the project query in checkAndUpdateEndaomentProject.ts to exclude cancelled projects. These modifications suggest a refinement of project-related data handling, specifically around project status and identification attributes.

Changes

File	Change Summary
src/entities/project.ts	Removed endaomentId?: string property from ProjectUpdate class
src/services/cronJobs/checkAndUpdateEndaomentProject.ts	Updated project query to filter out cancelled projects by adding statusId condition

Possibly related PRs

• Feat/Endaoment project update feature #1892: Adds endaomentId property to Project and ProjectUpdate classes, potentially conflicting with current changes

Suggested reviewers

• mohammadranjbarz
• CarlosQ96

Poem

🐰 A rabbit's tale of projects neat,
Where cancelled dreams no longer compete
Endaoment's whisper fades away
Simplifying code's ballet
Hop, hop, refactor with delight! 🌟

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/services/cronJobs/checkAndUpdateEndaomentProject.ts (1)

24-26: Consider extracting the magic number for organizationId.

The hardcoded value 5 for organizationId should be moved to a named constant or configuration for better maintainability and clarity.

+const ENDAOMENT_ORGANIZATION_ID = 5;

 const projects = await Project.find({
-  where: { organizationId: 5, statusId: Not(ProjStatus.cancelled) },
+  where: { organizationId: ENDAOMENT_ORGANIZATION_ID, statusId: Not(ProjStatus.cancelled) },
 });

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 448da9e and 1c37bc0.

📒 Files selected for processing (2)

• src/entities/project.ts (0 hunks)
• src/services/cronJobs/checkAndUpdateEndaomentProject.ts (2 hunks)

💤 Files with no reviewable changes (1)

• src/entities/project.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: test

🔇 Additional comments (3)

src/services/cronJobs/checkAndUpdateEndaomentProject.ts (3)

3-3: LGTM!

The Not operator import is correctly added and necessary for the query modification.

---

24-26: LGTM! The query modification looks good.

Excluding cancelled projects from updates is a logical improvement.

---

24-26: Verify the impact of endaomentId removal.

The AI summary mentions that endaomentId was removed from the ProjectUpdate class. However, this code still uses project.endaomentId. Let's verify this doesn't cause any issues.