-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Don't Merge Until Build] Update - Commented fill all shots button #335
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be its own PR that preps for posting to the app store, like changing the sign up email requirement and maybe other stuff
We can add onto it if want, I just wanted to have something locked and loaded so it was ready to go |
If so, currently the restriction on email being verified and from oregonstate is disabled by a TESTING constant being set to true. This PR should set that to false. I'll leave it to you so you know where this constant is |
Found it and set it to false |
Hmm, now that I look at it, it would be better if the "fill all shots" button depend on the "TESTING" constant. And prob any other testing related stuff |
idk if people still use it, but the test user login could probably also be modified to use TESTING constant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description:
This PR simply comments out the "fill all shots" Text in the input screen so it is ready to go when we deploy the application.
I have commented it out instead of deleting it so it is still available when developing
Screenshot: