Skip to content

Commit

Permalink
change to use binary scoring mode
Browse files Browse the repository at this point in the history
  • Loading branch information
adrianaixba committed Nov 1, 2023
1 parent 58fc6b6 commit e3a06d7
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion core/audits/bf-cache.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class BFCache extends Audit {
supportedModes: ['navigation', 'timespan'],
guidanceLevel: 2,
requiredArtifacts: ['BFCacheFailures'],
scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
scoreDisplayMode: Audit.SCORING_MODES.BINARY,
};
}

Expand Down
6 changes: 3 additions & 3 deletions core/test/fixtures/user-flows/reports/sample-flow-result.json
Original file line number Diff line number Diff line change
Expand Up @@ -3628,7 +3628,7 @@
"title": "Page didn't prevent back/forward cache restoration",
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 1,
"scoreDisplayMode": "metricSavings",
"scoreDisplayMode": "binary",
"guidanceLevel": 2
}
},
Expand Down Expand Up @@ -10408,7 +10408,7 @@
"title": "Page didn't prevent back/forward cache restoration",
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 1,
"scoreDisplayMode": "metricSavings",
"scoreDisplayMode": "binary",
"guidanceLevel": 2
}
},
Expand Down Expand Up @@ -21023,7 +21023,7 @@
"title": "Page didn't prevent back/forward cache restoration",
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 1,
"scoreDisplayMode": "metricSavings",
"scoreDisplayMode": "binary",
"guidanceLevel": 2
}
},
Expand Down
4 changes: 2 additions & 2 deletions core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -5573,8 +5573,8 @@
"id": "bf-cache",
"title": "Page prevented back/forward cache restoration",
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 0.5,
"scoreDisplayMode": "metricSavings",
"score": 0,
"scoreDisplayMode": "binary",
"displayValue": "2 failure reasons",
"details": {
"type": "table",
Expand Down
12 changes: 6 additions & 6 deletions shared/localization/locales/en-US.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions shared/localization/locales/en-XL.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e3a06d7

Please sign in to comment.