Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @google-cloud/translate to v3 #1235

Merged
merged 1 commit into from
May 13, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 2, 2019

This PR contains the following updates:

Package Type Update Change References
@​google-cloud/translate dependencies major ^2.1.2 -> ^3.0.0 source

Release Notes

googleapis/nodejs-translate

v3.0.1

Compare Source

04-09-2019 12:19 PDT

Fixes
  • fix(build): include build/protos in npm package (#​241)
Dependencies
Documentation / Samples
  • Change region tag to translate_translate_text_with_glossary_beta (#​240)
  • docs(samples): Add samples for translate v3 beta (#​234)
Internal / Testing Changes
  • refactor: use execSync for tests (#​237)

v3.0.0

Compare Source

BREAKING CHANGE:

This release introduces the grpc dependency.

In some environments, this will trigger a native compilation.

Implementation Changes
New Features
  • feat: add version v3beta1 (#​232)
Dependencies
  • chore(deps): update dependency typescript to ~3.4.0 (#​231)
Documentation
Internal / Testing Changes
  • chore: publish to npm using wombat (#​227)
  • build: use per-repo npm publish token (#​225)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2019
@renovate renovate bot force-pushed the renovate/google-cloud-translate-3.x branch 6 times, most recently from e73ff12 to 8eef74a Compare April 6, 2019 21:40
@renovate renovate bot force-pushed the renovate/google-cloud-translate-3.x branch 9 times, most recently from f131135 to 59cf807 Compare April 16, 2019 12:46
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 16, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 16, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Apr 17, 2019

@ace-n, can you take on this functions sample?

 1) Validate encoding field
       should fail if encoding field is missing.:
     Error: expected 400 "Bad Request", got 404 "Not Found"
      at Test._assertStatus (node_modules/supertest/lib/test.js:268:12)
      at Test._assertFunction (node_modules/supertest/lib/test.js:283:11)
      at Test.assert (node_modules/supertest/lib/test.js:173:18)
      at localAssert (node_modules/supertest/lib/test.js:131:12)
      at /tmpfs/src/github/nodejs-docs-samples/functions/speech-to-speech/functions/node_modules/supertest/lib/test.js:128:5
      at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3)
      at parser (node_modules/superagent/lib/node/index.js:916:18)
      at IncomingMessage.res.on (node_modules/superagent/lib/node/parsers/json.js:19:7)
      at endReadableNT (_stream_readable.js:1064:12)
      at _combinedTickCallback (internal/process/next_tick.js:139:11)
      at process._tickCallback (internal/process/next_tick.js:181:9)

@ace-n
Copy link
Contributor

ace-n commented Apr 17, 2019

I didn't write these samples. @crwilcox is this something you (or the client libraries team more broadly) can address?

(If not, ping me and I'll take another look.)

@renovate renovate bot force-pushed the renovate/google-cloud-translate-3.x branch 3 times, most recently from 896a169 to 584ca22 Compare April 18, 2019 20:36
@fhinkel
Copy link
Contributor

fhinkel commented Apr 20, 2019

Who wrote the functions samples? @ace-n

@ace-n
Copy link
Contributor

ace-n commented Apr 20, 2019

#777 - looks like this was an ML team's sample. @beccasaurus do you know if someone officially owns these (specifically GCF samples that use X API), or is that something our respective teams (@sgreenberg <--> @andrewsg) should chat about?

@beccasaurus
Copy link
Contributor

beccasaurus commented Apr 20, 2019

I'm unfamiliar with the OCR sample.

speech-to-speech was authored by @ricalo and the code supports the Adding speech translation to your Android app solution.

It should certainly be kept up-to-date, dependency-wise etc :)

You have my +1 on the dependency upgrade.

@beccasaurus beccasaurus self-requested a review April 20, 2019 01:58
@ace-n
Copy link
Contributor

ace-n commented Apr 20, 2019

@ricalo is the failing test something you'd be willing to investigate? (Based on @beccasaurus' comment, it seems like you intended to maintain it - apologies for assuming otherwise. If not - then we should figure out who does own it going forward. 🙂)

@ricalo
Copy link
Member

ricalo commented Apr 20, 2019

Yes, I can take issues related to the speech-to-speech sample.
It looks like it's a problem with the latest functions emulator. Check googlearchive/cloud-functions-emulator/issues/321.

Is only the speech-to-speech sample failing? I'd assume that any sample that uses the emulator should experience similar issues. In any case, a workaround could be to downgrade the emulator installed in the shared build script. I'd rather let the emulator team fix the issue on their side.

I can look in more detail at this next week, but let me know what you think in the meantime.

@fhinkel
Copy link
Contributor

fhinkel commented Apr 22, 2019

Thanks @ricalo for looking into this.

@renovate renovate bot force-pushed the renovate/google-cloud-translate-3.x branch from 584ca22 to 04ddcb6 Compare April 22, 2019 16:26
@ricalo
Copy link
Member

ricalo commented Apr 25, 2019

Hi @fhinkel. Any idea why the checks seem to be stuck in Waiting to be reported? Some of the comments in the emulator repo indicate that the problem might have been fixed. I'd like to see if that solves the issues here.

@renovate renovate bot force-pushed the renovate/google-cloud-translate-3.x branch from 04ddcb6 to eca1849 Compare April 30, 2019 17:21
@fhinkel
Copy link
Contributor

fhinkel commented May 2, 2019

@ricalo hard to tell, sometimes it's just a reporting problem. If you have access to the internal tool, you can restart individual tests.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 2, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 2, 2019
@fhinkel
Copy link
Contributor

fhinkel commented May 2, 2019

All tests passed. Should I merge?

@renovate renovate bot force-pushed the renovate/google-cloud-translate-3.x branch from eca1849 to c3f4c12 Compare May 2, 2019 18:06
@ricalo
Copy link
Member

ricalo commented May 2, 2019

LGTM, but it's not my call.

@renovate renovate bot force-pushed the renovate/google-cloud-translate-3.x branch 3 times, most recently from 11e2704 to 6b15044 Compare May 8, 2019 14:51
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 8, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 8, 2019
@renovate renovate bot force-pushed the renovate/google-cloud-translate-3.x branch from 6b15044 to 8125bd0 Compare May 8, 2019 17:17
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 11, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 11, 2019
@fhinkel
Copy link
Contributor

fhinkel commented May 11, 2019

@gguuss The iot tests time out here. Could you have a look? Seems unrelated.

  15 passing (1m)
  1 failing
  1) should send command message to device:
      AssertionError [ERR_ASSERTION]: false === true
      + expected - actual
      -false
      +true
      at Context.it (system-test/manager.test.js:302:10)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:189:7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants