Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #2653] login link #3245

Closed
wants to merge 3 commits into from
Closed

[Issue #2653] login link #3245

wants to merge 3 commits into from

Conversation

acouch
Copy link
Collaborator

@acouch acouch commented Dec 17, 2024

Summary

Fixes #2653

NOTE: still working on mobile.

Time to review: 5 mins

Changes proposed

Adds login link.

Desktop

image

doug-s-nava and others added 2 commits December 16, 2024 11:09
@doug-s-nava
[Issue #2654] Next login flow backend (#3182)
ca566bd 
* adds route at /api/auth/callback to be hit by the flask API at the completion of the login flow 
* adds jwt token parsing logic
* adds support for a "SESSION_SECRET" env var
* adds a User page for temporary testing
@acouch
[Issue #2653] Add login link
b6a2bfd
@acouch acouch changed the base branch from main to feature/nextjs-auth December 17, 2024 14:44
@coilysiren
Copy link
Collaborator

🤔 wondering what I did wrong with the code owners file for it to be requesting basically everyone on this PR... 🤔

@acouch acouch marked this pull request as draft December 17, 2024 14:46
@acouch acouch closed this Dec 18, 2024
@acouch acouch deleted the acouch/issue-2653-login-link branch December 18, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coilysiren coilysiren Awaiting requested review from coilysiren

@mdragon mdragon Awaiting requested review from mdragon

@andycochran andycochran Awaiting requested review from andycochran

@btabaska btabaska Awaiting requested review from btabaska

@doug-s-nava doug-s-nava Awaiting requested review from doug-s-nava

@chouinar chouinar Awaiting requested review from chouinar

@widal001 widal001 Awaiting requested review from widal001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Implement header sign in component
3 participants
@acouch @coilysiren @doug-s-nava