[Unticketed] Ignore vulnerability for issue with pending fix #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdragon
approved these changes
Dec 19, 2024
doug-s-nava
pushed a commit
that referenced
this pull request
Dec 30, 2024
## Summary ### Time to review: __2 mins__ ## Changes proposed Ignore [GHSA-v778-237x-gjrc](GHSA-v778-237x-gjrc) Cleaned up old ignores that _should_ be fixed by now ## Context for reviewers This vulnerability is in a dependency pulled in by the Github CLI. A [fix was made](cli/cli@1af4210) but no new release has occurred, likely due to the holidays. https://github.com/cli/cli/releases As this vulnerability already would exist in our image, ignoring it for now seems uneventful, and the issue shouldn't persist beyond the holidays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Time to review: 2 mins
Changes proposed
Ignore GHSA-v778-237x-gjrc
Cleaned up old ignores that should be fixed by now
Context for reviewers
This vulnerability is in a dependency pulled in by the Github CLI. A fix was made but no new release has occurred, likely due to the holidays. https://github.com/cli/cli/releases
As this vulnerability already would exist in our image, ignoring it for now seems uneventful, and the issue shouldn't persist beyond the holidays.