[Issue #3289] content cleanup #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
requested review from
andycochran,
btabaska and
doug-s-nava
as code owners
acouch
changed the title
acouch
force-pushed
the
acouch/issue-3289-content-cleanup
branch
from
c3387a9 to
c98e18a
Compare
acouch
force-pushed
the
acouch/issue-3289-content-cleanup
branch
from
c98e18a to
eb03abe
Compare
acouch
commented
Jan 6, 2025
doug-s-nava
reviewed
Jan 9, 2025
| (chunks: ReactNode) => ( | ||
| <Link | ||
| target="_blank" | ||
| className="usa-link--external text-bold" |
There was a problem hiding this comment.
the github links are bold but the other links on the page aren't. Not sure this is an issue with the branch not being rebased or not, but it looks a bit weird as is
| @@ -11,4 +13,11 @@ describe("Process Content", () => { | |||
|
|
|||
| expect(ProcessH1).toBeInTheDocument(); | |||
| }); | |||
| it("github link", () => { | |||
There was a problem hiding this comment.
can you make this test more descriptive? maybe gitHubIssueLink renders a component with correct props? This could also be rewritten to look at the href on the node, which would be slightly more helpful
Co-authored-by: doug-s-nava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3289
Time to review: 2 mins
Changes proposed
Small changes from previous PR:
gitHubIssueLink()function