Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #3247] login header follow up fixes #3480

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

doug-s-nava
Copy link
Collaborator

Summary

Fixes #3247

Time to review: 5 mins

Changes proposed

  • fix bug where mobile login dropdown appeared on top of mobile menu
  • improve spacing on mobile login dropdown

Context for reviewers

Test Steps

  1. run the app on main
  2. visit http://localhost:3000 on mobile
  3. VERIFY: looks like "before" screenshots below
  4. restart app on this branch and refresh
  5. VERIFY: looks like "after" screenshots below

Additional information

Before

Screenshot 2025-01-09 at 4 26 05 PM
Screenshot 2025-01-09 at 4 25 58 PM

After

Screenshot 2025-01-09 at 4 23 01 PM

Screenshot 2025-01-09 at 4 22 52 PM

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@doug-s-nava doug-s-nava changed the base branch from main to feature/nextjs-auth January 9, 2025 21:27
@doug-s-nava doug-s-nava merged commit 96f6b65 into feature/nextjs-auth Jan 10, 2025
8 checks passed
@doug-s-nava doug-s-nava deleted the 3247-follow-ups branch January 10, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement header logged in state including user email
2 participants