[Issue 743] Sprint burndown by points #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code copied from deliverable percent complete copied the dataframe from self.dataset instead of using the filtered dataset passed to the method. This introduced a bug that this commit fixes.
Also adds a TODO for setting up incremental exports
Replaces references to "points" and "tasks" string with Enum in DeliverablePercentComplete metric class
4 tasks
lucasmbrown-usds
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Overall looks excellent. On the question of referring to things as either "tasks" or "stories" or something else, I wonder if it makes sense to use the same language as GitHub for consistency and clarity, and call them "issues"?
But I don't have too strong opinions about this, either way is fine for me.
Nice work!
This helps align terminology in the project with terminology used in GitHub
Storing the value of self.unit.value to the variable unit is confusing because it doesn't indicate the type or how that variable will be used This commit changes the value to unit_col to indicate that it will be used to select the unit column and adds a type hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for calculating sprint burndown by points instead of tickets, and fixes a few other requested changes that @lucasmbrown-usds made in #685
Fixes #743
Time to review: 10 mins
Changes proposed
SprintBurndownto accept aunitparameter which uses the sameUnitenum asDeliverablePercentCompleteSprintBurndown.calculate()to use theunitparameter when calculating burndown, allowing us to calculate burndown by sprint and ticketsSprintBurndownUnitinDeliverablePercentCompleteto avoid using the hardcoding"tasks"or"points"as a string outside of the enumContext for reviewers
git fetch origin && git checkout issue-743-sprint-burndown-by-pointspoetry run analytics calculate sprint_burndown --sprint-file data/sprint-data.json --issue-file data/issue-data.json --sprint "Sprint 10" --unit points --show-resultsOpen questions
taskstotickets?Additional information