Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Canary resources to Terraform #865

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Add Canary resources to Terraform #865

merged 8 commits into from
Dec 20, 2023

Conversation

aplybeah
Copy link
Contributor

Summary

Fixes #562

Time to review: x mins

Changes proposed

  • Add synthetic Canary resource
  • Add IAM role, S3 bucket, Lambda

Context for reviewers

This task is to export the settings from #771 to terraform.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@aplybeah aplybeah requested review from acouch and chouinar December 12, 2023 19:02
@aplybeah aplybeah marked this pull request as ready for review December 12, 2023 19:02
@aplybeah aplybeah merged commit ed35648 into main Dec 20, 2023
6 checks passed
@aplybeah aplybeah deleted the alsia/add-canary-tf branch December 20, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acouch acouch acouch approved these changes

@chouinar chouinar Awaiting requested review from chouinar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add Synthetic Canary and Related Artifacts to Terraform
2 participants
@aplybeah @acouch