Add collection list and manages block #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyanshunayan
changed the title
chrizandr
requested changes
Jul 13, 2020
priyanshunayan
commented
Jul 16, 2020
| @@ -347,8 +348,12 @@ | |||
| }, | |||
| { | |||
| "@id": "vocab:dummyClassCollection", | |||
| "@type": "hydra:Class", | |||
| "@type": "Collection", | |||
There was a problem hiding this comment.
@chrizandr Do we want hydra:Class here or hydra:Collection or vocab:DummyClassCollection? Going by the default apidoc we are using, it seems like DummyClassCollection will be a good choice, but in the spec repo, i have seen using 'hydra:Collection' only as a type.
chrizandr
approved these changes
Jul 20, 2020
sameshl
added a commit
to sameshl/hydrus
that referenced
this pull request
Aug 10, 2020
Fix tests for collections array in EntryPoint endpoint response (HTTP-APIs/hydra-python-core#40). Fix tests for expanded ids.
chrizandr
pushed a commit
to HTTP-APIs/hydrus
that referenced
this pull request
Aug 13, 2020
* Use expanded @id for EntryPoint in doc_parse function * Get resource name from expanded @id * Get foreign key relationships through expanded ids * get vocab route from apidoc to build vocab endpoint * remove hardcoding of vocab keyword on link header * remove hardcoding of vocab keyword in checkEndpoint function * Fix hardcoding of vocab in getType function * Fix hardcoding of vocab keyword in finalize_response function * Fix hardcoding of vocab keyword in generate_iri_mappings * Fix hardcoding of vocab keyword in get_link_props * Remove hardcoding of vocab keyword in conftest.py * Fix hardcoded vocab - test_app.py * Remove hardcoded vocab - test_curd.py * Get the parsed_class name directly * Remove accidental import of pdb * Use correct conditions for propertyNotGiven test * Fix tests as now collections array in entrypoint response * Correctly get mananged class type and title for collections * Fix multiple add and delete endpoints for parsed classes * Fix tests for updates in the hydra-python-core repo Fix tests for collections array in EntryPoint endpoint response (HTTP-APIs/hydra-python-core#40). Fix tests for expanded ids. * Add check for db setup * Add check for PUT operation before inserting objects * Fix IRI template tests * Revert "Add check for db setup" This reverts commit e152fa2. * Update doc_writer_sample.py and its output with latest changes at core library * Update Drone doc with latest changes at core * Fix PEP8 errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #39
Checklist
Description
This PR does following things:
Earlier it was ambiguous to identify a collection. Implementation of collection array and manages block explicitly marks a resource collection.
Change logs