-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Pydantic to version 2 #160
Closed
Closed
Changes from 18 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
6891ade
Bump Pydantic to version 2
ThomasLaPiana c491758
Add Pydantic 2 to Action Matrix
ThomasLaPiana 153bf2d
checkin
ThomasLaPiana 7693bcb
feat: remove data qualifiers
ThomasLaPiana 3e486b1
feat: more qualifier removals
ThomasLaPiana 7371ff7
Merge branch 'ThomasLaPiana-remove-data-qualifiers' into ThomasLaPian…
ThomasLaPiana 20a0785
fix: mypy and pylint
ThomasLaPiana d55e284
fix more failing tests
ThomasLaPiana 5f2c86c
fix version and fides_key validation test failures
ThomasLaPiana a718e17
fix missing defaults
ThomasLaPiana c329f44
clean up more test failures
ThomasLaPiana bfb8d3d
fix more errors
ThomasLaPiana 25e5b80
fix parent key validation
ThomasLaPiana 73edf8b
get everything passing (by removing two tests)
ThomasLaPiana 126e4be
feat: update CI checks for new pydantic versions
ThomasLaPiana cc4d782
update requirements file, remove python 3.8 and add 3.12 to supported…
ThomasLaPiana ba08cf1
remove python 3.12 from the matrix
ThomasLaPiana 12ef6a8
fix static checks
ThomasLaPiana 63d2795
docs: changelog
ThomasLaPiana 40d4faa
re-add tests and fix privacy declaration checks
ThomasLaPiana d82bf8c
Merge branch 'fideslang-3' into ThomasLaPiana-bump-pydantic-2
ThomasLaPiana 537537c
fix flexible default test
ThomasLaPiana 191f6df
fix static checks
ThomasLaPiana 9ec615a
fix the validators on our custom fideskey types to be json schema valid
ThomasLaPiana 43abfb7
turned off strict checking for the registry id
ThomasLaPiana e7de840
add more None defaults to optional types
ThomasLaPiana a66a4ce
remove all uses of URL since they might cause issues with database st…
ThomasLaPiana 557aebf
remove a validator on System that caused issues when loading from Orm…
ThomasLaPiana b87a229
remove deprecation tests and update model (root) validators
ThomasLaPiana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -93,9 +93,9 @@ jobs: | |
Pytest-Matrix: | ||
strategy: | ||
matrix: | ||
python_version: ["3.8", "3.9", "3.10", "3.11"] | ||
pydantic_version: ["1.8.2", "1.9.2", "1.10.9"] | ||
pyyaml_version: ["5.4.1", "6.0"] | ||
python_version: ["3.9", "3.10", "3.11"] | ||
pydantic_version: ["2.2.1", "2.3.0", "2.4.2", "2.5.0"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are the most recent ones, but Pydantic moves fast so we'll need to keep an eye on this |
||
pyyaml_version: ["5.4.1", "6.0.1"] | ||
runs-on: ubuntu-latest | ||
continue-on-error: true | ||
steps: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3.8 wasn't playing nicely, so I axed it. It is almost EOL and we can only make the matrix so large
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, how do we generally communicate things like this to customers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than changelog, it'll automatically fail to pip install if they have an older version.
Afaik most people are using Docker containers, this would be most disruptive to customers using the CLI