Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible Legal Basis = True #184

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Nov 15, 2023

Closes #PROD-1264

Description Of Changes

Update fideslang defaults to match what should happen when a user creates a System outside of Compass, as there shouldn't be limitations by default.

Code Changes

Update flexible legal basis for processing to make it non-optional with a True default.

Steps to Confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! once the compass PR is deployed (https://github.com/ethyca/fides-services/pull/126) it'd be nice just to get some end-to-end testing in place to make sure we haven't missed any "gotchas" 👍

@pattisdr
Copy link
Contributor Author

@adamsachs end-to-end testing looked good, I'd like to merge this and publish a small fideslang release, and then get the fides PR merged if you're good with it.


I pushed alpha tag 2.2.2a0, added to Fides requirements ethyca/fides#4434, and then used that latest commit in a fidesplus end-to-end test to get compass staging functionality.

Things look great to me - you create a System with Privacy Declarations via the API directly, they default to having a flexible legal basis. Compass data seems to be coming in as True or False now instead of having nulls.

@pattisdr pattisdr merged commit e1ad8de into main Nov 16, 2023
33 checks passed
@pattisdr pattisdr deleted the PROD-1264_fideslang_flexible_legal_basis branch November 16, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants