Re-enable NUMA memory binding on newer kernels #1207
Conversation
* lib/ljsyscall/syscall/linux/syscalls.lua: More robustly create multi-word bitmasks. * src/lib/numa.lua: Remove facility for blacklisting kernel versions. Re-enable bind_to_numa_node generally.
|
I hate that this is so complicated, but this PR seems to make it simpler overall. 👍 Since this touches ljsyscall, maybe @justincormack has more insight. |
|
I also wonder about our relation with upstream ljsyscall, we have snabbco#1122 lying around. Would be nice to sync with upstream (both directions.) |
|
Regarding upstream, there's justincormack/ljsyscall#193 sitting around because I am a bad person and haven't done the last-mile there; so on the up side of things there won't be conflicts with upstream :P |
|
One problem about upstream is that I was reluctant to switch to LuaJit 2.1 branch as there has never actually been a proper release, and some of the PRs were not compatible due to syntactic differences. There are a couple of options, 1. fix the differences with some (probably a bit ugly) workarounds 2. drop support for the 2.0 branch 3. switch to raptorjit as the upstream... |
|
I will try to get in the workarounds upstream. |
lib/ljsyscall/syscall/linux/syscalls.lua: More robustly create
multi-word bitmasks.
src/lib/numa.lua: Remove facility for blacklisting kernel versions.
Re-enable bind_to_numa_node generally.