ENH: Add Python Jupyter Notebook testing procedure #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
reviewed
Jan 5, 2023
dzenanz
approved these changes
Jan 5, 2023
|
Looks really cool! |
thewtex
approved these changes
Jan 5, 2023
tbirdso
force-pushed
the
manylinux-options
branch
from
bdc5501 to
68f3ead
Compare
Adds job to `build-test-package-python` workflow that retrieves a built Linux Python wheel artifact previously output by the workflow and uses it to test Jupyter Notebooks in the `examples/` folder of the external module. For initial implementation only Linux wheels are tested with the Python version fixed at 3.10. To coincide with the Github Actions Linux runner image and machine architecture, only the `_2_28-x64` wheel is used. Closes InsightSoftwareConsortium#49 .
tbirdso
force-pushed
the
add-notebook-check
branch
from
af158b6 to
a79a8ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds job to
build-test-package-pythonworkflow that retrieves a built Linux Python wheel artifact previously output by the workflow and uses it to test Jupyter Notebooks in theexamples/folder of the external module.For initial implementation only Linux wheels are tested with the Python version fixed at 3.10. To coincide with the Github Actions Linux runner image and machine architecture, only the
_2_28-x64wheel is used.Depends on #17. Tested in https://github.com/tbirdso/ITKSplitComponents/actions/runs/3843342651. Closes #49 .
EDIT: Note that the ITKSplitComponents test job fails because the ITKSplitComponents example notebook needs to be updated (current kernel is python2). What is important is that the newly built package is correctly installed and the notebook test runs, which is confirmed by looking back through the logs.