Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add network diagnostics callback #1119

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

feat: add network diagnostics callback #1119

wants to merge 13 commits into from

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Feb 1, 2024 •
edited by kholood-ea
Loading

Description of the change

Add Instabug.onNetworkDiangosticsHandler callback.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-13680

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

abdelhamid-f-nasser and others added 12 commits January 29, 2024 10:38
@abdelhamid-f-nasser
feat(example): add nested complex views (#1111)
9a8703d 
Jira ID: MOB-13737
@ahmedAlaaInstabug
fix hybrid mode code push version init (#1108)
e17074a
@abdelhamid-f-nasser
chore(android): ignore jetbrains ide run configurations (#1110)
4161fdb 
Jira ID: MOB-13736
@a7medev
ci: migrate macos machines to m1 (#1114)
2ed0f24
@a7medev
chore(android): add native set network diagnostics callback
aab01e8
@a7medev
chore(ios): add native set network diagnostics callback
c2f75c5
@a7medev
feat: add on network diagnostics handler
0613776
@a7medev
test(android): test native set network diagnostics callback
395b314
@a7medev
fix(android): resolve failures with old mocks by using MockReflected
84186ed 
Rewrite the tests for `reportCurrentViewChange` and `reportScreenChange` to use `MockReflected` since they get broken while adding tests for the network diagnostics callback.
@a7medev
test(ios): test native set network diagnostics callback
8cf9acf
@a7medev
fix: align the name of native method
58ccf05
@a7medev
test: test network diagnostics callback in JS
89f67fd
@a7medev a7medev added pending-android Waiting for Android release pending-ios Waiting for iOS release Dream11 labels Feb 1, 2024
@a7medev a7medev self-assigned this Feb 1, 2024
@abdelhamid-f-nasser abdelhamid-f-nasser removed pending-android Waiting for Android release pending-ios Waiting for iOS release labels Feb 10, 2024
Base automatically changed from dev to master February 10, 2024 10:23
@HeshamMegid HeshamMegid dismissed ahmedAlaaInstabug’s stale review February 10, 2024 10:23

The base branch was changed.

@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as draft March 6, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug left review comments

@abdelhamid-f-nasser abdelhamid-f-nasser Awaiting requested review from abdelhamid-f-nasser

At least 1 approving review is required to merge this pull request.

Assignees

@a7medev a7medev

Labels
Dream11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @ahmedAlaaInstabug @abdelhamid-f-nasser