-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename offline to offchain #1533
Conversation
1bc65d4
to
640d6ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new .sql file is probaby needed since the schema has changed.
Also could you fill the autogenerated check-list of the pr, especially the Migration
paragraph which is relevant here?
There are some build failures in CI |
640d6ab
to
4080175
Compare
There are still 2 failing tests:
|
603ba40
to
610c382
Compare
a6b0adc
to
248dd5e
Compare
248dd5e
to
6466fb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
0fc020a
to
dc5c65a
Compare
dc5c65a
to
6552149
Compare
6552149
to
29b555e
Compare
904b7b9
to
cc82db1
Compare
Description
this fixes #1532
Checklist
fourmolu
on version 0.10.1.0 (which can be run withscripts/fourmolize.sh
)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.