1847 - add logging to Rollbacks #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmdv
force-pushed
the
1847-Rollbacks-in-conway
branch
from
62a18e2 to
f761f3c
Compare
kderme
reviewed
Oct 14, 2024
kderme
reviewed
Oct 14, 2024
kderme
reviewed
Oct 14, 2024
Cmdv
force-pushed
the
1847-Rollbacks-in-conway
branch
from
a8816cd to
8cab25a
Compare
Cmdv
force-pushed
the
1847-Rollbacks-in-conway
branch
2 times, most recently
from
0f546d1 to
dac9abe
Compare
|
The rollback summary looks great! |
Cmdv
force-pushed
the
1847-Rollbacks-in-conway
branch
from
dac9abe to
32f6a5f
Compare
sgillespie
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #1597 #1847
Adding some login to rollbacks for a clearer picture of what is happening.
Also refactored code and moved functionality to
cardano-db/library.Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.