Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dRep Search Test and Governance Action Validation Using IDs #2611

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Improve dRep Search Test and Governance Action Validation Using IDs #2611

merged 5 commits into from
Jan 9, 2025

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Jan 8, 2025

List of changes

  • Check both CIP129 and CIP105 dRep on search dRep test
  • Update governance action search to use IDs instead of titles and validate using IDs, as some governance action might be data not verifiable
  • Add CIP129 DRep conversion service to convert dRep hash to CIP129 based on script

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested review from mesudip and removed request for jdyczka and MSzalowski January 8, 2025 06:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

✅ All checks succeeded

@kneerose kneerose mentioned this pull request Jan 8, 2025
Open
39 tasks
mesudip
mesudip approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kneerose kneerose merged commit 355de00 into develop Jan 9, 2025
9 of 13 checks passed
@kneerose kneerose deleted the fix/dRep-sort-and-govAction-search-test branch January 9, 2025 10:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

@kneerose
This PR is in the tag: develop-355de00e6954fb5985e5a960dbbd12ec93764bab , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

@kneerose
This PR is in the tag: develop-355de00e6954fb5985e5a960dbbd12ec93764bab , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

@kneerose
This PR is in the tag: develop-355de00e6954fb5985e5a960dbbd12ec93764bab , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip