fix/#620: 마스킹 해제, 로그 파일 90일동안 보존 되도록 수정 #621
Open
+2
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hwangdaesun
reviewed
Jan 9, 2025
Comment on lines
9
to
20
| <encoder class="ch.qos.logback.core.encoder.LayoutWrappingEncoder"> | ||
| <layout class="com.gaebaljip.exceed.common.log.MaskingPatternLayout"> | ||
| <maskPattern>\"(?i).*email.*"\s*:\s*\"(.*?)\"</maskPattern> | ||
| <maskPattern>\"(?i).*password.*"\s*:\s*\"(.*?)\"</maskPattern> | ||
| <maskPattern>\"(?i).*height.*"\s*:\s*(\d+)</maskPattern> | ||
| <maskPattern>\"(?i).*weight.*"\s*:\s*(\d+)</maskPattern> | ||
| <maskPattern>\"(?i).*targetWeight.*"\s*:\s*(\d+)</maskPattern> | ||
| <maskPattern>\"(?i).*age.*"\s*:\s*(\d+)</maskPattern> | ||
| <maskPattern>\"(?i).*etc.*"\s*:\s*\"(.*?)\"</maskPattern> | ||
| <maskPattern>\"(?i).*activity.*"\s*:\s*\"(.*?)\"</maskPattern> | ||
| <pattern>${CONSOLE_LOG_PATTERN}</pattern> | ||
| </layout> |
There was a problem hiding this comment.
개인정보 고려해서 etc랑 password는 마스킹 살리는 게 좋지 않을까요?
There was a problem hiding this comment.
pwd는 마스킹 해도 될 것 같은데 etc는 한번 마스킹하면 다시 못 되돌릴텐데 etc도 마스킹하나요? 그때 나중에 수사 이런 것 때문에 90일동안 로그 남겨둔다고 했는데 etc도 기록해야 될 것 같다는 생각이 들어요
There was a problem hiding this comment.
etc가 개인 알러지 상태 작성하는 거랑 관련된 건데 데이터베이스에 저장할 때 암호화하니깐 로그 저장하는 것도 암호화해야한다고 생각했어요. 확실히 기억이 안 나서 슬랙에 함 물어보는 게 좋을 것 같아요.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌관련 이슈
close #620
🔑 주요 변경사항