Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asm: program re-entry at vbl #68

Closed
wants to merge 1 commit into from
Closed

asm: program re-entry at vbl #68

wants to merge 1 commit into from

Conversation

SimpleTease
Copy link
Contributor

No description provided.

@SimpleTease
Copy link
Contributor Author

mrboom-libretro/mrboom.c

Lines 10796 to 10804 in 46f3a16

vblavbl2x353:
IN(READDBl(eax),READDW(edx));
R(TEST(8,READDBl(eax),8,(db)8));
R(JE(vblavbl2x353));
R(XOR(32,READDD(eax),32,(dd)READDD(eax)));
R(XOR(32,READDD(edx),32,(dd)READDD(edx)));
directjeu:
CALL(master1);
trtyrtrtyrtyrtyrtyrtytyrrtyrtytyryrtrty:

 vblavbl2x353: 
 IN(READDBl(eax),READDW(edx)); 
==> m.nosetjmp = 2
==> exits program


 R(TEST(8,READDBl(eax),8,(db)8)); 
 R(JE(vblavbl2x353)); 

@@@  this gets skipped
 R(XOR(32,READDD(eax),32,(dd)READDD(eax))); 
 R(XOR(32,READDD(edx),32,(dd)READDD(edx))); 
@@@  this gets skipped


==> re-entry here
 directjeu: 
 CALL(master1); 
 trtyrtrtyrtyrtyrtyrtytyrrtyrtytyryrtrty: 

I saw this when using a debugger. A bunch of printfs can also verify this behavior.

@frranck
Copy link
Collaborator

frranck commented Nov 14, 2020

its just setting eax and edx to 0, prob it's not getting used in master1

@frranck
Copy link
Collaborator

frranck commented Nov 14, 2020

maybe fixing this #36 would make more sense?

@SimpleTease
Copy link
Contributor Author

its just setting eax and edx to 0, prob it's not getting used in master1

Okay. Just checking to be safe.

maybe fixing this #36 would make more sense?

I did check out the issue but don't have a Switch. And can't get Retroarch Emscripten to work on my machine... :grumpy_cat:

@SimpleTease SimpleTease deleted the patch-21 branch November 17, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants