Replace String Class with conversion to String

[lesoup-mxd]

The earlier approach raised compile errors, and created an unnecessary object. This approach should solve both and make the return more uniformal

[lesoup-mxd]

Compiles!

[Jensen-holm]

Hi lesoup, thanks for your PR.

I don't fully understand the need for the string change, could you explain a bit more?

[Jensen-holm]

I just discovered this when looking at the latest change log from Mojo

I think that this would be a better fix overall. If you could implement this then I will merge the pr.

[lesoup-mxd]

Sure)On Dec 3, 2024 18:24, Jensen Holm ***@***.***> wrote: I just discovered this when looking at the latest change log from Mojo image.png (view on web) I think that this would be a better fix overall. If you could implement this then I will merge the pr. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[lesoup-mxd]

Yea, seems better. Also, I see a couple variable declarations using the old "let" expr. that need to be updated

[lesoup-mxd]

It's present on your blog, too, so it would be a good idea to fix asap. Also, I found a couple other backends instead of relying on python modules, which seems like a wise idea

[Jensen-holm]

I agree with all of the things that you're saying, however I don't really have the time or energy to implement these changes myself.

At the time I created this project Mojo was in a much earlier stage of development, and the way that I implemented this was the standard at the time. I don't plan to personally keep up with the changes of Mojo, since I have other projects that I want to spend my time on.

Personally, I no longer use FireTCP myself and it is more of a 'toy' project to me now. But if this is something that you use and would like to improve on, I can create issues for these improvements and assign them to you.