socks5 support #2543
Merged
socks5 support #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socks5 support via environment variable, e.g. SOCKS5_PROXY=localhost:1080 yay ...
Jguer
reviewed
Dec 19, 2024
pkg/runtime/runtime.go
Outdated
| @@ -39,10 +41,20 @@ func NewRuntime(cfg *settings.Configuration, cmdArgs *parser.Arguments, version | |||
| logger := text.NewLogger(os.Stdout, os.Stderr, os.Stdin, cfg.Debug, "runtime") | |||
| runner := exe.NewOSRunner(logger.Child("runner")) | |||
|
|
|||
| var transport = &http.Transport{} | |||
There was a problem hiding this comment.
Can you copy the default transport? I think this works
http.DefaultTransport.(*http.Transport).Clone() There was a problem hiding this comment.
of course it is possible. I'm not an expert in Go at all :)
Jguer
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang implementation of
http.Clientdoes not handle socks5 support via LD_PRELOAD (a.k.a. tsocks/proxychains). Proposed patch adds explicit socks5 support via environment variable, e.g.SOCKS5_PROXY=localhost:1080 yay -Ss vivado.