Merge pull request #178 from JuliaDiff/generic

Fix generic-ness and improve inference
JuliaDiff · Dec 29, 2023 · 7e4915a · 7e4915a
2 parents 50ebf92 + 929832e
commit 7e4915a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "FiniteDiff"
 uuid = "6a86dc24-6348-571c-b903-95158fe2bd41"
-version = "2.21.1"
+version = "2.22.0"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

diff --git a/src/epsilons.jl b/src/epsilons.jl
@@ -22,7 +22,7 @@ end
     return eps(T)
 end
 
-default_relstep(v::Type, T) = default_relstep(v(), T)
+default_relstep(::Type{V}, T) where V = default_relstep(V(), T)
 @inline function default_relstep(::Val{fdtype}, ::Type{T}) where {fdtype,T<:Number}
     if fdtype==:forward
         return sqrt(eps(real(T)))

diff --git a/src/jacobians.jl b/src/jacobians.jl
@@ -194,7 +194,7 @@ function finite_difference_jacobian(
             x_save = ArrayInterface.allowed_getindex(vecx, i)
             epsilon = compute_epsilon(Val(:forward), x_save, relstep, absstep, dir)
             _vecx1 = setindex(vecx, x_save+epsilon, i)
-            _x1 = reshape(_vecx1, axes(x))
+            _x1 = ArrayInterface.restructure(x,_vecx1)
             vecfx1 = _vec(f(_x1))
             dx = (vecfx1-vecfx) / epsilon
             return dx